Support Python 3.12 #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Confirmed that pytest with Windows is not working. Skip Windows for now. It seems that the error has been existing before Cython 3.0 upgrade. Thus, we can skip Windows for now. https://github.com/chezou/rectools-lightfm/actions/runs/10412191347/job/28837492302
Author
|
@feldlime If you have time, can you allow to run GH actions? |
This was referenced Dec 7, 2024
Author
|
@feldlime Yes, please! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support LightFM for Python 3.12, adpoting to Cython 3.0 is needed.
This PR allows the installation of lightfm over Python 3.12.